feat: garm v0.1.5 #158
Open
feat: garm v0.1.5 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bavarianbidi
reviewed
Sep 9, 2024
| @@ -1,5 +1,3 @@ | |||
| # SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
Let's add PROJECT to the list of generated files in the license-scanner-script:
https://github.com/mercedes-benz/garm-operator/blob/main/hack/verify-license.sh#L22
bavarianbidi
requested changes
Sep 10, 2024
api/v1alpha1/enterprise_types.go
Outdated
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
|
||
| "github.com/mercedes-benz/garm-operator/pkg/util/conditions" | ||
| ) | ||
|
|
||
| // EnterpriseSpec defines the desired state of Enterprise | ||
| type EnterpriseSpec struct { | ||
| CredentialsName string `json:"credentialsName"` | ||
| CredentialsRef corev1.TypedLocalObjectReference `json:"credentialsRef"` |
There was a problem hiding this comment.
As discussed, let's introduce a new API version (e.g. v1beta1) to cover the change in the CredentialsRef with a conversion.
| group: garm-operator | ||
| kind: GitHubCredentials | ||
| path: github.com/mercedes-benz/garm-operator/api/v1alpha1 | ||
| version: v1alpha1 |
There was a problem hiding this comment.
new API groups should be in v1beta1
| group: garm-operator | ||
| kind: GitHubEndpoint | ||
| path: github.com/mercedes-benz/garm-operator/api/v1alpha1 | ||
| version: v1alpha1 |
There was a problem hiding this comment.
new API groups should be in v1beta1
| group: garm-operator | ||
| kind: GarmServerConfig | ||
| path: github.com/mercedes-benz/garm-operator/api/v1alpha1 | ||
| version: v1alpha1 |
There was a problem hiding this comment.
new API groups should be in v1beta1
this adds the conversion generator from https://github.com/kubernetes/code-generator to generate conversion code Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
code got generated by make conversion Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
rafalgalaw
force-pushed
the
feat/garm-v0.1.5
branch
from
88fcd0d
to
4231a28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement the new set of changes and api changes garm requires for its version v0.1.5. This includes: